Merged
Conversation
Package `@aztec/simulator` contained a weird amalgamation of a generic "circuit simulator" (that could execute kernels, which are mostly vanilla noir circuits) and a very specific "aztec simulator" that executed aztec contract functions with a very particular set of oracles always provided by PXE. This caused a weird split, since both packages usually have to be edited at the same time as they're tightly coupled. This PR tries to remove most of Aztec's specific stuff into PXE, to what we call the `ContractFunctionSimulator` for private, leaving `simulator` only as a thin abstraction on top of the `acvm` with extra niceties, such as oracle recording capabilities and error decoding.
Contributor
Docs PreviewYou can check your preview here. |
benesjan
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextversion of #14598 fixing merge conflicts