Skip to content

refactor: pxe simulator cherry pick#14667

Merged
Thunkar merged 2 commits intonextfrom
gj/pxe_simulator_cherry_pick
Jun 2, 2025
Merged

refactor: pxe simulator cherry pick#14667
Thunkar merged 2 commits intonextfrom
gj/pxe_simulator_cherry_pick

Conversation

@Thunkar
Copy link
Contributor

@Thunkar Thunkar commented Jun 2, 2025

next version of #14598 fixing merge conflicts

Thunkar added 2 commits June 2, 2025 04:32
Package `@aztec/simulator` contained a weird amalgamation of a generic
"circuit simulator" (that could execute kernels, which are mostly
vanilla noir circuits) and a very specific "aztec simulator" that
executed aztec contract functions with a very particular set of oracles
always provided by PXE. This caused a weird split, since both packages
usually have to be edited at the same time as they're tightly coupled.

This PR tries to remove most of Aztec's specific stuff into PXE, to what
we call the `ContractFunctionSimulator` for private, leaving `simulator`
only as a thin abstraction on top of the `acvm` with extra niceties,
such as oracle recording capabilities and error decoding.
@Thunkar Thunkar requested a review from benesjan June 2, 2025 04:56
@Thunkar Thunkar self-assigned this Jun 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Docs Preview

You can check your preview here.

@Thunkar Thunkar added this pull request to the merge queue Jun 2, 2025
Merged via the queue into next with commit ad837fe Jun 2, 2025
5 checks passed
@Thunkar Thunkar deleted the gj/pxe_simulator_cherry_pick branch June 2, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants